Upgrade YesSQL 3.3.0 #12959
Merged
Upgrade YesSQL 3.3.0 #12959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Functional tests are failing on SQL Server |
Why it doesn't show up on the checks here? I need to check if something related or not |
|
We don't run the functional tests on all databases on standard checks. |
|
I see, I thought we run them ;) One more thing does SQL Server connection string is using trusted connection? I might need to run the tests on my laptop with all database providers |
|
@hishamco good idea about the connection, that might be the reason. |
sebastienros
approved these changes
Dec 19, 2022
|
It's passing now 👏 |
|
I'm not sure if have a docs about Trusted connection for SQL Server /cc @agriffard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/sebastienros/yessql/releases/tag/v3.3.0