Introduce OrchardCore.Testing APIs

[hishamco]

This is one of the PRs that I'm working on testing part of Orchard Core, the plan is to provide an essential testing APIs infrastructure for creating unit tests easily for OC APIs and modules

For reference #11865 (comment)
Fixes #11865.

[MichaelPetrinolis]

@hishamco weekend is over but i will try to get time for it this week.

[MichaelPetrinolis]

@hishamco why is preferable to use the UseCulture attribute in tests instead of using the CultureScope ?

[hishamco]

We could but I did it as a wrapper, attributes are easier to use

[MichaelPetrinolis]

@hishamco I merged main into a new branch. I have some failed tests, I believe due to HttpContextAccessor not set and PermissionsContext. You can check it out here https://github.com/MichaelPetrinolis/OrchardCore/tree/merge_testing

[MichaelPetrinolis]

@Piedone @hishamco I think that we should try to merge this PR (when is complete) for v2.0.0
When it gets outdated again, it will be time-consuming bringing up all the changes.
There is a number difference in tests, seven tests were moved to another test project

[hishamco]

You're right @MichaelPetrinolis could you please commit directly here, I will spend time today to make it ready, also adding your commits here is useful to have a credit for you :)

Hope to get this finished before the end of next week

[MichaelPetrinolis]

@hishamco I don't have permission to directly push to your branch

[hishamco]

You're not in OC team?!!

[MichaelPetrinolis]

don't know, I usually send PRs from my fork

[hishamco]

You're not in OC team?!!

Seems you're not because I didn't see the member label beside your comment

So I will look to your changes, and see how it goes

[MichaelPetrinolis]

Ι can send a PR to your branch, if you can perform a merge commit

[MichaelPetrinolis]

the PR is ready, there are some tests that fail, I think because the HttpContextAccessor is not properly set. Also, I did not include the readme.md in the nav configuration and the check fails.

[hishamco]

I did not include the readme.md in the nav configuration and the check fails.

Is it there before?

[MichaelPetrinolis]

I did a quick check, and it was not. Obviously, we should add it.

[hishamco]

Look I will check if I can merge your commits locally

[Piedone]

Before anything else, what I told previously needs to be addressed:

Also, you may want to look into AutoMocker: I briefly checked out the code and I see a lot of manual dependency resolution with mocks, while this library takes care of that.

[MichaelPetrinolis]

Before anything else, what I told previously needs to be addressed:

Also, you may want to look into AutoMocker: I briefly checked out the code and I see a lot of manual dependency resolution with mocks, while this library takes care of that.

Maybe we should extract and merge the OrchardCore.Testing library from OrchardCore.Tests and in another issue refactor the tests to use AutoMocker.

[Piedone]

This PR adds a lot of new stuff, which isn't needed with AutoMocker. So I don't see why we'd add these, and then remove them in a second step, instead of not adding them in the first place.

[MichaelPetrinolis]

Hello @hishamco, is there anything else I can do to contribute to this PR?

[hishamco]

Sorry @MichaelPetrinolis for late I will try to make this as a top of my ToDo list

[github-actions]

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

[MikeAlhayek]

for instructions on how to resolve the merge conflicts due to #16572 please follow the step listed in this comment.

[github-actions]

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

[github-actions]

Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it.