Add IClientIpAddressAccessor interface for accessing client IP Address

[MikeAlhayek]

@jtkech

[jtkech]

Looks good but IOrchardHelper is most commonly used to provide Razor extensions, particularly for decoupled cms, never seen injected elsewhere, so maybe better to provide an HttpContext extension.

[MikeAlhayek]

@jtkech I understand. IOrchardHelper is injected when AddOrchardCore() extension is built. So it is a service that would always be available by default. I chose IOrchardHelper because one time I have a convo with @sebastienros and he suggested against adding extension for HttpContext directly. Since this is an extension of OC it maybe best if extend OC classes instead of .NET.

[jtkech]

Okay but not sure when more related to a given class and to not have too many undifferentiated IOrchardHelper extensions, personally I prefer httpContext.GetClientIpAddress() than orchardHelper.GetClientIpAddress(), but no problem if @sebastienros prefers.

[MikeAlhayek]

I personally also find httpContext.GetClientIpAddress() more appealing than orchardHelper.GetClientIpAddress(). @sebastienros can you chime in here to know which route is best for OC?

[sebastienros]

My suggestion would be to have a custom service abstraction as an interface in Infrastructure.Abstractions. This would also allow for mocking in tests. Mike suggests IClientIpAddressAccessor.GetIpAddressAsync()

[MikeAlhayek]

I created an interface IClientIpAddressAccessor as per @sebastienros recommendation.