Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent Assertions tests #14068

Closed
wants to merge 1 commit into from
Closed

Fluent Assertions tests #14068

wants to merge 1 commit into from

Conversation

agriffard
Copy link
Member

@hishamco
Copy link
Member

hishamco commented Aug 4, 2023

I might disagree because we already using xUnit. We could use some extensions to simplify the assertion rather than introducing a new library that will change the entire unit tests

@agriffard
Copy link
Member Author

Damn, a thumb down emoji.

@agriffard agriffard closed this Aug 4, 2023
@hishamco
Copy link
Member

hishamco commented Aug 4, 2023

Don't take it in person :) I might create a PR in the future to simplify some assertions which will do the exact same thing. Thanks to point to this

@agriffard
Copy link
Member Author

There are no tests on this class:

There are multiple StringExtensions.cs files in different modules that add different extensions methods which are not tested.

If we manage to list some of them, we could open some issues labelled good first issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants