Add StyleCop.Analyzers and enable some basic suggestions

src/OrchardCore.Build/Dependencies.props

@@ -54,6 +54,7 @@
     <PackageManagement Include="Shortcodes" Version="1.3.3" />
     <PackageManagement Include="SixLabors.ImageSharp.Web" Version="3.0.1" />
     <PackageManagement Include="StackExchange.Redis" Version="2.6.122" />
+    <PackageManagement Include="StyleCop.Analyzers" Version="1.1.118" />
     <PackageManagement Include="System.Linq.Async" Version="6.0.1" />
     <PackageManagement Include="xunit" Version="2.5.0" />
     <PackageManagement Include="xunit.analyzers" Version="1.2.0" />

src/OrchardCore.Build/OrchardCore.Commons.props

@@ -50,4 +50,8 @@
     </None>
   </ItemGroup>
 
+  <ItemGroup>
+    <PackageReference Include="StyleCop.Analyzers" PrivateAssets="all" />
+  </ItemGroup>
+
 </Project>

src/OrchardCore.Modules/OrchardCore.Localization/AdminMenu.cs

@@ -22,7 +22,7 @@ public AdminMenu(IStringLocalizer<AdminMenu> localizer)
             S = localizer;
         }
 
-        ///<inheritdocs />
+        /// <inheritdocs />
         public Task BuildNavigationAsync(string name, NavigationBuilder builder)
         {
             if (String.Equals(name, "admin", StringComparison.OrdinalIgnoreCase))

src/OrchardCore.Modules/OrchardCore.Notifications/Migrations/NotificationMigrations.cs

@@ -15,8 +15,8 @@ public int Create()
             .Column<bool>("IsRead")
             .Column<DateTime>("ReadAtUtc")
             .Column<DateTime>("CreatedAtUtc")
-            .Column<string>("Content", column => column.WithLength(NotificationConstants.NotificationIndexContentLength))
-            , collection: NotificationConstants.NotificationCollection
+            .Column<string>("Content", column => column.WithLength(NotificationConstants.NotificationIndexContentLength)),
+            collection: NotificationConstants.NotificationCollection
         );
 
         SchemaBuilder.AlterIndexTable<NotificationIndex>(table => table

src/OrchardCore/OrchardCore.Apis.GraphQL.Client/ContentTypeCreateResourceBuilder.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Text;
 
@@ -55,7 +56,7 @@ internal string Build()
 
             for (var i = 0; i < _contentPartBuilders.Count; i++)
             {
-                sbo.Append(_contentPartBuilders[i].Build()).AppendLine((i == (_contentPartBuilders.Count - 1)) ? "" : ",");
+                sbo.Append(_contentPartBuilders[i].Build()).AppendLine((i == (_contentPartBuilders.Count - 1)) ? String.Empty : ",");
             }
 
             sbo.Append('}').AppendLine();

src/OrchardCore/OrchardCore.Localization.Abstractions/CultureDictionaryRecord.cs

@@ -11,7 +11,7 @@ public class CultureDictionaryRecord
         /// Creates new instance of <see cref="CultureDictionaryRecord"/>.
         /// </summary>
         /// <param name="messageId">The message Id.</param>
-        /// <param name="translations">a list of translations</param>
+        /// <param name="translations">a list of translations.</param>
         public CultureDictionaryRecord(string messageId, params string[] translations)
             : this(messageId, null, translations)
         {
@@ -23,7 +23,7 @@ public CultureDictionaryRecord(string messageId, params string[] translations)
         /// </summary>
         /// <param name="messageId">The message Id.</param>
         /// <param name="context">The message context.</param>
-        /// <param name="translations">a list of translations</param>
+        /// <param name="translations">a list of translations.</param>
         public CultureDictionaryRecord(string messageId, string context, string[] translations)
         {
             Key = GetKey(messageId, context);

src/OrchardCore/OrchardCore.OpenId.Core/OpenIdExtensions.cs

@@ -46,14 +46,10 @@ public static OpenIddictCoreBuilder UseOrchardManagers(this OpenIddictCoreBuilde
 
             // Register proxy delegates so that the Orchard managers can be directly
             // resolved from the DI using the non-generic, Orchard-specific interfaces.
-            builder.Services.TryAddScoped(provider => (IOpenIdApplicationManager)
-                provider.GetRequiredService<IOpenIddictApplicationManager>());
-            builder.Services.TryAddScoped(provider => (IOpenIdAuthorizationManager)
-                provider.GetRequiredService<IOpenIddictAuthorizationManager>());
-            builder.Services.TryAddScoped(provider => (IOpenIdScopeManager)
-                provider.GetRequiredService<IOpenIddictScopeManager>());
-            builder.Services.TryAddScoped(provider => (IOpenIdTokenManager)
-                provider.GetRequiredService<IOpenIddictTokenManager>());
+            builder.Services.TryAddScoped(provider => (IOpenIdApplicationManager)provider.GetRequiredService<IOpenIddictApplicationManager>());
+            builder.Services.TryAddScoped(provider => (IOpenIdAuthorizationManager)provider.GetRequiredService<IOpenIddictAuthorizationManager>());
+            builder.Services.TryAddScoped(provider => (IOpenIdScopeManager)provider.GetRequiredService<IOpenIddictScopeManager>());
+            builder.Services.TryAddScoped(provider => (IOpenIdTokenManager)provider.GetRequiredService<IOpenIddictTokenManager>());
 
             return builder;
         }