Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust 3 file names #14151

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Adjust 3 file names #14151

merged 2 commits into from
Aug 16, 2023

Conversation

jtkech
Copy link
Member

@jtkech jtkech commented Aug 16, 2023

No description provided.

@MikeAlhayek
Copy link
Member

MikeAlhayek commented Aug 16, 2023

This is good. But I think if you are going down this path, you should set rule id SA1649 to warning. Rebuild the project and fix all the files that will error. Then rename the PR to something like Enforcing StyleCop rule SA1649 (File name should match first type name)

@jtkech
Copy link
Member Author

jtkech commented Aug 16, 2023

Yes, as we can do step by step when we agree to introduce new rules, I may try to set SA1649 if I have time. In the meantime, just because I noticed these 3 files during a recent OC meeting, even before we merge the StyleCop PR, so just like sometimes I do some formatting even if the related rule is not yet set.

Anyway nothing crucial ;)

@MikeAlhayek
Copy link
Member

Step SA1649 is what you did here. It ensures that the file name matches the first type name in the file. So I think it makes sense to fix them all in the same PR. but, sure if not we can do a follow up PR.

@MikeAlhayek MikeAlhayek merged commit 0aa2628 into main Aug 16, 2023
3 checks passed
@MikeAlhayek MikeAlhayek deleted the jtkech/files-renaming branch August 16, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants