Make UserMenu and LoginMenu extensible to using drivers
#14214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtkech
reviewed
Aug 26, 2023
src/OrchardCore.Modules/OrchardCore.Users/TwoFactorAuthenticationStartup.cs
Outdated
Show resolved
Hide resolved
|
@jtkech incase you want to review this one again. I added shape table provider and used morphing to reduce reuse views. Let me know if you see something else or you are good with this. |
jtkech
reviewed
Aug 29, 2023
src/OrchardCore.Modules/OrchardCore.Users/UserMenuShapeTableProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/UserMenuShapeTableProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/UserMenuShapeTableProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/UserMenuShapeTableProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/UserMenuShapeTableProvider.cs
Outdated
Show resolved
Hide resolved
…rchardCore into refactor-user-menu
|
@jtkech can you please review this PR when possible? I like to merge it soon |
sebastienros
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14213
To inject new menu items in either the
LoginMenuorUserMenuyou can implement and register an implementation ofDisplayDriver<UserMenu>. TheDetaildisplayType is used to create the front end menu whereas theDetailAdminis used to create the admin menu.Here is a screenshot from TheTheme theme.
Here is a screenshot from TheAdmin theme.