Make TriggerEvent retnrun WorkflowExecutionContext #14281
Conversation
|
@MikeAlhayek Could you please review this PR ? thank you |
src/OrchardCore/OrchardCore.Workflows.Abstractions/Services/IWorkflowManager.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
@hyzx86 we just merged another PR that introduces a change to the same interface. I am okay with your changes since its modifying the same interface in current release.
Please update the the 1.8 release notes (https://github.com/OrchardCMS/OrchardCore/blob/main/src/docs/releases/1.8.0.md) by adding your change to the breaking change under the Workflow Module section. You may add something like this
The method
public async Task TriggerEventAsync(string name, IDictionary<string, object> input = null, string correlationId = null, bool isExclusive = false, bool isAlwaysCorrelated = false)was changed to returnTask<IEnumerable<WorkflowExecutionContext>>instead.
|
@MikeAlhayek Done |
|
@hyzx86 this was one was missed and should have been in 1.8. Can you please move the docs to the 1.9 release notes? |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
|
@MikeAlhayek Done |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
There are scenarios where we would like to be able to get what workflows were triggered, but the current code does not return that