Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Github release action on Windows #14707

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Fix the Github release action on Windows #14707

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b3906e
Fix the release Workflow
MikeAlhayek Nov 16, 2023
506c8d2
add alias
MikeAlhayek Nov 16, 2023
0aa12f4
Addressing feedback
MikeAlhayek Nov 17, 2023
35c11bc
remove ARG
MikeAlhayek Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
ARG BUILDPLATFORM
MikeAlhayek marked this conversation as resolved.
Show resolved Hide resolved
FROM --platform=$TARGETOS golang:alpine AS build
MikeAlhayek marked this conversation as resolved.
Show resolved Hide resolved

FROM mcr.microsoft.com/dotnet/sdk:8.0 AS build-env
LABEL stage=build-env
WORKDIR /app
Expand All @@ -7,7 +10,10 @@ COPY ./src /app
RUN dotnet publish /app/OrchardCore.Cms.Web -c Release -o ./build/release --framework net8.0

# Build runtime image
FROM mcr.microsoft.com/dotnet/aspnet:8.0
FROM mcr.microsoft.com/dotnet/aspnet:8.0-nanoserver-1809 AS build_windows
FROM mcr.microsoft.com/dotnet/aspnet:8.0 AS build_linux
FROM build_${TARGETOS} AS aspnet

EXPOSE 80
ENV ASPNETCORE_URLS http://+:80
WORKDIR /app
Expand Down
7 changes: 6 additions & 1 deletion Dockerfile-CI
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
# This Docker file is intended for the CI
# A prerequisite is a published application in the .build/release

FROM mcr.microsoft.com/dotnet/aspnet:8.0
ARG BUILDPLATFORM
MikeAlhayek marked this conversation as resolved.
Show resolved Hide resolved
FROM --platform=$TARGETOS golang:alpine AS build

FROM mcr.microsoft.com/dotnet/aspnet:8.0-nanoserver-1809 AS build_windows
FROM mcr.microsoft.com/dotnet/aspnet:8.0 AS build_linux
FROM build_${TARGETOS} AS aspnet

EXPOSE 80
ENV ASPNETCORE_URLS http://+:80
Expand Down