Update ResourceManager.cs to better handle resources that don't specify a version #14992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree company="AdvantageCS" |
MikeAlhayek
approved these changes
Jan 5, 2024
| if (resource == null | ||
| || (resourceDefinition.Version != null && new Version(resource.Version) < version)) | ||
| // Use the highest version of all matches. Resources that don't specify a version have the lowest priority. | ||
| if (resource == null || resource.Version == null || new Version(resource.Version) < version) |
There was a problem hiding this comment.
Please simplify code to this
resource?.Version is null
There was a problem hiding this comment.
@MikeAlhayek you could use the suggest feature in GitHub instead of writing the code yourself, it's quite helpful
hishamco
approved these changes
Jan 5, 2024
src/OrchardCore/OrchardCore.ResourceManagement/ResourceManager.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Hisham Bin Ateya <[email protected]>
|
@mroskamp creating a unit test will be plus |
…tion and ensure resource definitions that don't specify a version have the lowest priority.
|
@MikeAlhayek any comment or we can merge |
|
Thanks for your contribution @mroskamp |
giannik
pushed a commit
to giannik/OrchardCore
that referenced
this pull request
Jan 7, 2024
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ResourceManager.cs to better handle resources that don't specify a version
fixes #14991