Simplify Collection initialization (IDE0300) #15187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
requested review from
sfmskywalker,
deanmarcussen,
kevinchalet,
Jetski5822,
carlwoodhouse,
jtkech and
sebastienros
as code owners
|
I'm with & without the change, all the reactors will break the current PRs. I'm not disagree if all agree with the changes |
|
@hishamco It should not break other PR since the change is done on a single line. |
MikeAlhayek
requested review from
Piedone and
kevinchalet
and removed request for
kevinchalet,
sfmskywalker,
deanmarcussen,
Jetski5822,
carlwoodhouse,
jtkech,
sebastienros,
hishamco and
Piedone
Piedone
reviewed
Jan 29, 2024
|
@Piedone yes this PR is only to simplify the collection initialization. I submitting couple PR to keep them simpler or easier to digest. |
Piedone
approved these changes
Jan 29, 2024
hishamco
pushed a commit
that referenced
this pull request
Feb 1, 2024
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.