Optimize ElasticIndexingService #15227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it is. |
Skrypt
reviewed
Feb 2, 2024
src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/Recipes/ElasticIndexRebuildStep.cs
Show resolved
Hide resolved
Skrypt
reviewed
Feb 2, 2024
src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/Recipes/ElasticIndexResetStep.cs
Show resolved
Hide resolved
Skrypt
reviewed
Feb 2, 2024
...OrchardCore/OrchardCore.Search.Elasticsearch.Core/Services/ElasticIndexInitializerService.cs
Show resolved
Hide resolved
Skrypt
reviewed
Feb 2, 2024
src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/Services/ElasticIndexingService.cs
Show resolved
Hide resolved
Skrypt
reviewed
Feb 2, 2024
src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/Services/ElasticIndexingService.cs
Outdated
Show resolved
Hide resolved
MikeAlhayek
commented
Feb 2, 2024
| .ToList(); | ||
| } | ||
|
|
||
| if (indexSettingsList.Count == 0) |
There was a problem hiding this comment.
Avoid Any when possible :)
Skrypt
reviewed
Feb 2, 2024
src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/Services/ElasticIndexingService.cs
Show resolved
Hide resolved
Skrypt
reviewed
Feb 2, 2024
src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/Services/ElasticIndexingService.cs
Outdated
Show resolved
Hide resolved
Skrypt
reviewed
Feb 2, 2024
src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/Services/ElasticIndexingService.cs
Outdated
Show resolved
Hide resolved
|
@Skrypt I did a benchmark to iterate over 1000 integers. Result summery is speed vs allocation!
Using List is faster but comes at the cost of allocation more as you expected. I'll modify the code to no use the list. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
MikeAlhayek
commented
Feb 3, 2024
src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/Services/ElasticIndexingService.cs
Outdated
Show resolved
Hide resolved
Skrypt
reviewed
Feb 5, 2024
src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/Services/ElasticIndexingService.cs
Show resolved
Hide resolved
Skrypt
reviewed
Feb 5, 2024
src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/Services/ElasticIndexingService.cs
Show resolved
Hide resolved
|
@Skrypt are you good with this PR? |
Skrypt
approved these changes
Feb 8, 2024
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Skrypt perhaps this is a more interesting PR that the other one?