DateNode -> DateTimeOffsetNode & DateNode2 -> DateTimeNode #15297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piedone
requested changes
Feb 11, 2024
| @@ -51,9 +51,9 @@ public Expression BuildOperation(in BuildExpressionContext context, ConstantExpr | |||
| } | |||
| } | |||
|
|
|||
| public class DateNode : OperatorNode | |||
| public class DateTimeOffsetNode : OperatorNode | |||
There was a problem hiding this comment.
Did you check if these don't break Audit Trail admin listing? Since these are indirectly used from DefaultAuditTrailAdminListFilterProvider.
There was a problem hiding this comment.
If we have a list of OperatorNode in a List that is serialized as Json then it will break.
And we (with Mike) don't remember configuring these for custom json serialization (might have missed it).
There was a problem hiding this comment.
If this could break anyone, I will close this then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address @Piedone comment here