Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login providers should not be visible if the service is not configured #15305

Merged
merged 3 commits into from
Feb 11, 2024
Merged

Login providers should not be visible if the service is not configured #15305

merged 3 commits into from
Feb 11, 2024

Conversation

lampersky
Copy link
Contributor

fixes #13863

/cc @MikeAlhayek

@lampersky
Copy link
Contributor Author

All tests pass in my environment, but it is failing here in ubuntu.

image

fail: Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware[1]
      An unhandled exception has occurred while executing the request.
      System.ArgumentException: An item with the same key has already been added. Key: PartName
         at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
         at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
         at OrchardCore.ContentManagement.GraphQL.FieldTypeExtensions.WithMetaData(FieldType fieldType, String name, Object value) in /_/src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Extensions/FieldTypeExtensions.cs:line [26](https://github.com/OrchardCMS/OrchardCore/actions/runs/7862582347/job/21452217647?pr=15305#step:6:27)

@MikeAlhayek
Copy link
Member

@lampersky can you please open an new issue with that? I think this is a new introduced by the last update we had for graphQL. It should be addressed. I seen it happen with other tests also

MikeAlhayek
MikeAlhayek requested changes Feb 11, 2024
View reviewed changes
Copy link
Member

@MikeAlhayek MikeAlhayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think some add these logs will help

src/OrchardCore.Modules/OrchardCore.Facebook/Login/Configuration/FacebookLoginConfiguration.cs Show resolved Hide resolved
src/OrchardCore.Modules/OrchardCore.GitHub/Configuration/GithubOptionsConfiguration.cs Show resolved Hide resolved
...rdCore.Modules/OrchardCore.Google/Authentication/Configuration/GoogleOptionsConfiguration.cs Show resolved Hide resolved
...rdCore.Modules/OrchardCore.Google/Authentication/Configuration/GoogleOptionsConfiguration.cs Show resolved Hide resolved
...re.Modules/OrchardCore.Microsoft.Authentication/Configuration/AzureADOptionsConfiguration.cs Show resolved Hide resolved
src/OrchardCore.Modules/OrchardCore.Twitter/Signin/Configuration/TwitterOptionsConfiguration.cs Show resolved Hide resolved
@MikeAlhayek MikeAlhayek merged commit 9e66231 into OrchardCMS:main Feb 11, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Closed
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
@lampersky @urbanit
Login providers should not be visible if the service is not configured (
af3c6aa 
OrchardCMS#15305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeAlhayek MikeAlhayek MikeAlhayek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facebook Login should not be visible if the service is not configured
2 participants
@lampersky @MikeAlhayek