Remove TitlePart wrapper when it is hidden

[douwinga]

Fixes #15382

[sebastienros]

@douwinga PR is fine, did you actually face an issue with this empty wrapper? Or did you find the ticket and wanted to help fix it.

[douwinga]

@sebastienros Just trying to contribute to become a better developer. Was looking for a ticket I could finish on my lunch break. This was the first one I found.

[sebastienros]

So we are hoping this doesn't break anything, the issue wasn't to fix an actual problem but something that looked odd. It's totally possible that some other feature was using (or could use in the future) these wrappers even if the shape was not rendered (e.g. content preview, placement, shape debugger, ...)

[douwinga]

Hmmm, I bet this change would actually cause an issue with admin templates and shape rendering. It would no longer obey the hide check. Should probably keep that check on the TitlePart.Edit. it seemed like an innocent change

[sebastienros]

If you can do some test and see if nothing is broken, otherwise we'll just revert the change.

[douwinga]

Ya, I will look tonight and try to fix any issues. Having an empty div isn't ideal. I wonder if these wrappers were just to give JavaScript something to target or something.

[sebastienros]

I wonder if these wrappers were just to give JavaScript something to target or something.

Definitely. Question is do these wrappers still like to have the div even if the part is not displayed ... I would say that if the wrapper doesn't bother, we should just keep it.

[MikeAlhayek]

I tested the change before merging and it worked as expected with no issues. But another set of eyes wont hurt.

[douwinga]

I was wrong. Having {{ Model.Parts.TitlePart | shape_render }} in an admin template does still obey the hidden setting. So far nothing else has broken either.

[douwinga]

It breaks with a placement.json with the following:

{
  "TitlePart_Edit": [
    {
      "place": "Parts:0",
      "displayType": "Edit"
    }
  ]
}

If we do the TitlePartOptions.GeneratedHidden check in TitlePart.Edit.cshtml it works correctly as the only thing that is broken is that it no longer is checking that and shows when it should be hidden.

I can do a PR to just have it check in TitlePart.Edit.cshtml too and not just ContentPart-TitlePart.Edit if we think we are not just going to revert this change.

[douwinga]

shape debugger

Not sure what that is to test