Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fluid 2.6.0 #15489

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Update Fluid 2.6.0 #15489

merged 2 commits into from
Mar 12, 2024

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Mar 11, 2024 •
edited
Loading

@hishamco
Copy link
Member Author

hishamco commented Mar 11, 2024 •
edited
Loading

@sebastienros is DelegateAccessor become a sealed class?

@sebastienros
Copy link
Member

Error: /home/runner/work/OrchardCore/OrchardCore/src/OrchardCore/OrchardCore.DisplayManagement.Liquid/LiquidViewTemplate.cs(102,36): error CS0509: 'ShapeAccessor': cannot derive from sealed type 'DelegateAccessor'

ouch

@hishamco
Copy link
Member Author

Related to sebastienros/fluid#611

/cc @lahma

@sebastienros
Copy link
Member

@hishamco can you just copy the code from the previous type? It's very minimal.

@hishamco
Copy link
Member Author

hishamco commented Mar 11, 2024 •
edited
Loading

This simple workaround to inherit from DelegateAccessor<object, object> instead

@hishamco
Copy link
Member Author

I think we're ready to merge

@lahma
Copy link
Contributor

lahma commented Mar 12, 2024

Yep, DelegateAccessor as base class doesn't make much sense when there's nothing to override from that type.

@hishamco
Copy link
Member Author

Are we fine with the current changes?

@hishamco hishamco merged commit 44500d0 into main Mar 12, 2024
5 checks passed
@hishamco hishamco deleted the hishamco/fluid branch March 12, 2024 16:07
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
@hishamco @urbanit
Update Fluid 2.6.0 (OrchardCMS#15489)
b86fd8f
This was referenced Apr 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

@agriffard agriffard Awaiting requested review from agriffard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hishamco @sebastienros @lahma