-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Azure Communication SMS #15539
Conversation
Way too many files changes here. It seems that you copied all the SMS files into a new module. All you should need to do
|
As I said it's WIP, I'm working on it :) |
This pull request has merge conflicts. Please resolve those before requesting a review. |
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it. |
for instructions on how to resolve the merge conflicts due to #16572 please follow the step listed in this comment. |
c991891
to
d98c12e
Compare
@MikeAlhayek could you please do a quick review |
I suggest moving the Twilio-related types into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hishamco here are some feedback. Also, please remove the template file changes from this PR.
Twilio provider should be kept in the Sms module.
src/OrchardCore.Modules/OrchardCore.Sms.Azure/AzureSmsPermissionProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Sms.Azure/AzureSmsPermissionProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Sms.Azure/AzureSmsPermissionProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Sms.Azure/AzureSmsPermissionProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Sms.Azure/AzureSmsPermissions.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Sms.Azure/Services/AzureSmsProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Sms.Azure/ViewModels/AzureSettingsViewModel.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Alhayek <[email protected]>
src/OrchardCore.Modules/OrchardCore.Sms.Azure/Services/AzureSmsProviderBase.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hishamco now you created naming inconsistency between UI and documentation. Please use "Azure Communication SMS" everywhere as the suggestions below. This will keep naming consistency, and allow us to add another SMS provider offered by Azure later when they decide to introduce a new service.
src/OrchardCore.Modules/OrchardCore.Sms.Azure/Services/DefaultAzureSmsProvider.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Alhayek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hishamco
Can you please search for the docs and the code for anything that say Azure Communication SMS and replace it with *Azure Communication. Because when we are in the SMS UI, the term SMS is implied. So we should not repeat it everywhere specially in the UI.
src/OrchardCore.Modules/OrchardCore.Sms.Azure/Drivers/AzureSettingsDisplayDriver.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Sms.Azure/Services/AzureSmsProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Sms.Azure/Services/DefaultAzureSmsProvider.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Alhayek <[email protected]>
Nothing except this docs |
If it's ok I will merge then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you did the string/replace.
src/OrchardCore.Modules/OrchardCore.Sms.Azure/OrchardCore.Sms.Azure.csproj
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Sms.Azure/Services/AzureSmsProviderBase.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Sms.Azure/Views/AzureSmsSettings.Edit.cshtml
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Alhayek <[email protected]>
I looked for what you asking for "Azure Communication SMS" not "Azure SMS" :) |
src/OrchardCore.Modules/OrchardCore.Sms.Azure/Services/AzureSmsProviderBase.cs
Outdated
Show resolved
Hide resolved
/backport to release/2.0 |
Started backporting to release/2.0: https://github.com/OrchardCMS/OrchardCore/actions/runs/11782162720 |
The first time I saw such BOT when it was introduced. |
Adds support for Azure Communication SMS