Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run preview_ci once a day #15551

Closed
wants to merge 2 commits into from
Closed

Run preview_ci once a day #15551

wants to merge 2 commits into from

Conversation

MikeAlhayek
Copy link
Member

Fix #15548

@Piedone
Copy link
Member

Piedone commented Mar 19, 2024

I started to work on this with a more complete solution: main...Lombiq:OrchardCore:issue/OCORE-151

@Piedone
Copy link
Member

Piedone commented Mar 19, 2024

And now done: #15552

@MikeAlhayek
Copy link
Member Author

@Piedone Check out the updated code in this PR. Maybe worth testing to see if we get the desired out come. This is is much shorter logic.

@Piedone
Copy link
Member

Piedone commented Mar 19, 2024

The dependent job instead of per-step checks is a good idea for less code, but it starts a separate VM just for that script. That seems wasteful for me.

Otherwise, I'd have loads of change requests to do things (in a way) that I've done. So if you're OK with it, I'd continue with that.

@MikeAlhayek
Copy link
Member Author

I'll close this PR and let you finish it :)

@Piedone
Copy link
Member

Piedone commented Mar 19, 2024

Thanks! I'm done there, actually.

Sorry about the wasted effort. Usually, I'm attentive enough to assign the issue, what I forgot this time, and you were too quick :).

@MikeAlhayek
Copy link
Member Author

Sorry about the wasted effort.

Never waste. Always learn something while trying something new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily preview package publish instead of on every commit to main
2 participants