-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up CodeRabbit for AI code reviews (Lombiq Technologies: OCORE-159) #15813
Conversation
WalkthroughThis update integrates the CodeRabbit AI tool into the OrchardCore project, enhancing the code review process with AI capabilities. It includes configuration settings for early access and review workflows, and documentation updates to guide contributors on interacting with AI reviews. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
.coderabbit.yaml (1)
3-5
: Consider adding more detailed documentation links directly related to each configuration section for better clarity.src/docs/guides/contributing/contributing-code.md (1)
70-70
: Clarify the expectations from contributors when interacting with CodeRabbit AI reviews, especially regarding the handling of potential inaccuracies.
It's still young :( :D. This can happen if you have two reviews close to each other, like if you open multiple PRs within a few minutes, or instruct it to review manually multiple times. Was this the case? |
probably opened multiple PR with in close time. |
Did you find this useful yet? So far it just extra unwelcome noise for me. |
same here 😀 |
It's a mixed bag. From where it actually added actionable comments (there were a few where it couldn't):
|
Please vote: #15935. |
This pull request has merge conflicts. Please resolve those before requesting a review. |
# Conflicts: # src/docs/guides/contributing/reviewing-pull-requests.md
Can we let some workflows trigger when files within specific folders change, such as this PR I don't think there's a need to execute Build, Functional Tests while your change in docs |
Yeah, some of the workflows already do that. A downside to not running the build is that we can't have a branch protection rule like currently to prevent merges if the build didn't complete. |
Actually, that's already the case for the fictional tests, just the CodeRabbit YAML file was an exception to the rule. |
Fixes #15439.
While I've set up CodeRabbit for the repository from the UI for now, so it'll work immediately, the long-term better option is to configure it from a file. So, here I'm adding that too (it'll take precedence over the UI config).