Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC project templates should show net8.0 only #16048

Merged
merged 5 commits into from
May 18, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions .github/ISSUE_TEMPLATE/release.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@ Update the source, so everything looks like on the new version.
- [ ] Update the `OrchardCore.Commons.props` file with `<VersionSuffix></VersionSuffix>` such that preview build numbers are not injected in packages. Verify the `VersionPrefix` tag matches the released version.
- [ ] Update module versions in `src/OrchardCore/OrchardCore.Abstractions/Modules/Manifest/ManifestConstants.cs`.
- [ ] Create a new milestone.
- [ ] Add final updates the to the release notes in the documentation. It should include the following, at least:
- Overview of the release's highlights and goals. What do you want people to remember this release for?
- Prerequisites. What framework version do you need, anything else to work with Orchard?
- Upgrade steps, any migration necessary from previous versions, and any breaking changes.
- [ ] Change the framework version(s) in the project templates, more specifically in `dotnetcli.host.json` and `template.json` files.
hishamco marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Add final updates to the release notes in the documentation. It should include the following, at least:
- Overview of the release's highlights and goals. What do you want people to remember this release for?
- Prerequisites. What framework version do you need, anything else to work with Orchard?
- Upgrade steps, any migration necessary from previous versions, and any breaking changes.
- [ ] Add the release notes documentation page to the documentation site's navigation in `mkdocs.yml` and remove it from `not_in_nav`.
- [ ] Update the documentation to mention the version in all places where the latest version is referenced, for example, but not limited to (do a search for the package version string): [Status in the root README](https://docs.orchardcore.net/en/latest/#status), CLI templates, commands, the [Creating a new decoupled CMS Website](https://docs.orchardcore.net/en/latest/guides/decoupled-cms/) guide.

Expand All @@ -40,9 +41,9 @@ Make sure everything works all right.

- [ ] Make sure that [`OrchardCore.Samples` works](https://github.com/OrchardCMS/OrchardCore.Samples).
- [ ] Test the [guides](https://docs.orchardcore.net/en/latest/guides/) with the NuGet packages from the Cloudsmith feed (branches under `release/` are automatically published too). Test at least the following guides:
- [Creating a modular ASP.NET Core application](https://docs.orchardcore.net/en/latest/guides/create-modular-application-mvc/)
- [Creating an Orchard Core CMS website](https://docs.orchardcore.net/en/latest/guides/create-cms-application/)
- [Creating a new decoupled CMS Website](https://docs.orchardcore.net/en/latest/guides/decoupled-cms/)
- [Creating a modular ASP.NET Core application](https://docs.orchardcore.net/en/latest/guides/create-modular-application-mvc/)
- [Creating an Orchard Core CMS website](https://docs.orchardcore.net/en/latest/guides/create-cms-application/)
- [Creating a new decoupled CMS Website](https://docs.orchardcore.net/en/latest/guides/decoupled-cms/)
- [ ] Re-certify Orchard Core for the latest major version of Red Hat Enterprise Linux if a new version has been released (e.g., v10 after v9). Refer to Orchard's [Red Hat Ecosystem Catalog profile](https://catalog.redhat.com/software/applications/detail/223797) for the previously certified version, the [Red Hat Customer Portal](https://access.redhat.com/articles/3078) for the latest version, and [our certification guide](https://docs.orchardcore.net/en/latest/topics/red-hat-ecosystem-catalog-certification/) for the certification steps.

### Prepare and publish Orchard Core Translations
Expand All @@ -59,16 +60,16 @@ Do the harder parts of making the release public. This should come after everyth

- [ ] Tag the head of `release/<version name>` with the version. Include `v` in the name, e.g. `v1.8.0`.
- [ ] Merge `release/<version name>` to `main`.
- You'll need to create a pull request.
- Merge it as a merge commit, not squash merge.
- If there are merge conflicts, then create a `release/<version name>-integration` branch and fix them there.
- You'll need to create a pull request.
- Merge it as a merge commit, not squash merge.
- If there are merge conflicts, then create a `release/<version name>-integration` branch and fix them there.
- [ ] Create and publish a release [on GitHub](https://github.com/OrchardCMS/OrchardCore/releases/new).
- Generate release notes.
- Add a link to the release notes in the docs (something like `For details on this version see the [release notes in the documentation](link here).`). Note that the docs will only be built once the branch is merged to `main`.
- Generate release notes.
- Add a link to the release notes in the docs (something like `For details on this version see the [release notes in the documentation](link here).`). Note that the docs will only be built once the branch is merged to `main`.
- [ ] Test the [guides](https://docs.orchardcore.net/en/latest/guides/) with the packages now automatically published to NuGet. Test at least the following guides:
- [Creating a modular ASP.NET Core application](https://docs.orchardcore.net/en/latest/guides/create-modular-application-mvc/)
- [Creating an Orchard Core CMS website](https://docs.orchardcore.net/en/latest/guides/create-cms-application/)
- [Creating a new decoupled CMS Website](https://docs.orchardcore.net/en/latest/guides/decoupled-cms/)
- [Creating a modular ASP.NET Core application](https://docs.orchardcore.net/en/latest/guides/create-modular-application-mvc/)
- [Creating an Orchard Core CMS website](https://docs.orchardcore.net/en/latest/guides/create-cms-application/)
- [Creating a new decoupled CMS Website](https://docs.orchardcore.net/en/latest/guides/decoupled-cms/)
- [ ] Update [Try Orchard Core](https://github.com/OrchardCMS/TryOrchardCore).

### Publicize the release
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
}
},
"usageExamples": [
"--framework net7.0",
"--orchard-version 1.6.0"
"--framework net8.0",
"--orchard-version 1.8.3"
Piedone marked this conversation as resolved.
Show resolved Hide resolved
]
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
{
"$schema": "http://json.schemastore.org/template",
"author": "Orchard Core Community and Contributors",
"classifications": [ "Web", "Orchard Core", "CMS" ],
"classifications": [
"Web",
"Orchard Core",
"CMS"
],
"name": "Orchard Core Cms Module",
"identity": "OrchardCore.Templates.Cms.Module",
"shortName": "ocmodulecms",
Expand All @@ -14,14 +18,6 @@
"description": "The target framework for the project.",
"datatype": "choice",
"choices": [
{
"choice": "net6.0",
"description": "Target net6.0"
},
{
"choice": "net7.0",
"description": "Target net7.0"
},
{
"choice": "net8.0",
"description": "Target net8.0"
Expand Down Expand Up @@ -80,4 +76,4 @@
"language": "C#",
"type": "project"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
}
},
"usageExamples": [
"--framework net7.0",
"--framework net8.0",
"--logger none",
"--orchard-version 1.6.0"
"--orchard-version 1.8.3"
]
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
{
"$schema": "http://json.schemastore.org/template",
"author": "Orchard Core Community and Contributors",
"classifications": [ "Web", "Orchard Core", "CMS" ],
"classifications": [
"Web",
"Orchard Core",
"CMS"
],
"name": "Orchard Core Cms Web App",
"identity": "OrchardCore.Templates.Cms.Web",
"shortName": "occms",
Expand All @@ -14,14 +18,6 @@
"description": "The target framework for the project.",
"datatype": "choice",
"choices": [
{
"choice": "net6.0",
"description": "Target net6.0"
},
{
"choice": "net7.0",
"description": "Target net7.0"
},
{
"choice": "net8.0",
"description": "Target net8.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
}
},
"usageExamples": [
"--framework net7.0",
"--orchard-version 1.6.0"
"--framework net8.0",
"--orchard-version 1.8.3"
]
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
{
"$schema": "http://json.schemastore.org/template",
"author": "Orchard Core Community and Contributors",
"classifications": [ "Web", "Orchard Core", "Mvc" ],
"classifications": [
"Web",
"Orchard Core",
"Mvc"
],
"name": "Orchard Core Mvc Module",
"identity": "OrchardCore.Templates.Mvc.Module",
"shortName": "ocmodulemvc",
Expand All @@ -14,14 +18,6 @@
"description": "The target framework for the project.",
"datatype": "choice",
"choices": [
{
"choice": "net6.0",
"description": "Target net6.0"
},
{
"choice": "net7.0",
"description": "Target net7.0"
},
{
"choice": "net8.0",
"description": "Target net8.0"
Expand All @@ -40,12 +36,11 @@
},
"sources": [
{
"modifiers": [
]
"modifiers": []
}
],
"tags": {
"language": "C#",
"type": "project"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
}
},
"usageExamples": [
"--framework net7.0",
"--orchard-version 1.6.0"
"--framework net8.0",
"--orchard-version 1.8.3"
]
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
{
"$schema": "http://json.schemastore.org/template",
"author": "Orchard Core Community and Contributors",
"classifications": [ "Web", "Orchard Core", "Mvc" ],
"classifications": [
"Web",
"Orchard Core",
"Mvc"
],
"name": "Orchard Core Mvc Web App",
"identity": "OrchardCore.Templates.Mvc.Web",
"shortName": "ocmvc",
Expand All @@ -14,14 +18,6 @@
"description": "The target framework for the project.",
"datatype": "choice",
"choices": [
{
"choice": "net6.0",
"description": "Target net6.0"
},
{
"choice": "net7.0",
"description": "Target net7.0"
},
{
"choice": "net8.0",
"description": "Target net8.0"
Expand All @@ -38,8 +34,7 @@
"defaultValue": "${TemplateOrchardVersion}"
}
},
"sources": [
],
"sources": [],
"tags": {
"language": "C#",
"type": "project"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
{
"$schema": "http://json.schemastore.org/template",
"author": "Orchard Project",
"classifications": [ "Web", "Orchard Core", "CMS" ],
"classifications": [
"Web",
"Orchard Core",
"CMS"
],
"name": "Orchard Core Theme",
"identity": "OrchardCore.Templates.Theme",
"shortName": "octheme",
Expand All @@ -14,14 +18,6 @@
"description": "The target framework for the project.",
"datatype": "choice",
"choices": [
{
"choice": "net6.0",
"description": "Target net6.0"
},
{
"choice": "net7.0",
"description": "Target net7.0"
},
{
"choice": "net8.0",
"description": "Target net8.0"
Expand Down