Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix show password button on the login screen (Lombiq Technologies: OCORE-172) #16098

Merged
merged 3 commits into from
May 19, 2024
Merged

Fix show password button on the login screen (Lombiq Technologies: OCORE-172) #16098

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42f51a0
Fix show password button on the login screen
Piedone May 19, 2024
f46f496
Merge remote-tracking branch 'official/main' into issue/OCORE-172
Piedone May 19, 2024
5f5ffcf
JS let
Piedone May 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OrchardCore.Modules/OrchardCore.Users/Views/LoginFormCredentials.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

<script at="Foot">
togglePassword = document.querySelector('#togglePassword');
password = document.querySelector('#Password');
password = document.querySelector('#@Html.IdFor(m => m.Password)');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the directive let before password and togglePassword. These are local variables

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the difference except the intellisense, both have "#Password" value

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old hard-coded ID that the script depended on was Password but the new one generated by asp-for="Password" is LoginForm_Password. This is why the script was broken.


togglePassword.addEventListener('click', function (e) {
type = password.getAttribute('type') === 'password' ? 'text' : 'password';
Expand Down