Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unreliable unit test #16145

Merged
merged 5 commits into from
May 25, 2024
Merged

Fix unreliable unit test #16145

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17f82e9
Fix flaky test.
gvkries May 23, 2024
ad70147
Don't use a timeout.
gvkries May 24, 2024
4f71603
Merge branch 'main' into gvkries/unit-test-16018
gvkries May 24, 2024
748050f
React to code review.
gvkries May 25, 2024
65fb0af
Merge branch 'main' into gvkries/unit-test-16018
gvkries May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions test/OrchardCore.Tests/Apis/GraphQL/Queries/RecentBlogPostsQueryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,17 @@ public async Task ShouldListBlogPostWhenCallingAQuery()
.WithField("displayText");
});

var nodes = result["data"]["recentBlogPosts"];
var jsonArray = result["data"]?["recentBlogPosts"]?.AsArray();

Assert.Equal(2, nodes.AsArray().Count);
Assert.Equal("Some sorta blogpost in a Query!", nodes[0]["displayText"].ToString());
Assert.Equal("Man must explore, and this is exploration at its greatest", nodes[1]["displayText"].ToString());
Assert.NotNull(jsonArray);
Assert.Equal(2, jsonArray.Count);

// The RecentBlogPosts query sorts the content items by CreatedUtc. If the
// test is executing too fast, both blog entries may have the same CreatedUtc
// value and ordering becomes random. Because of this, we do not assert the order
// of the result.
Assert.Contains("Some sorta blogpost in a Query!", jsonArray.Select(node => node["displayText"]?.ToString()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you save the result of jsonArray.Select(node => node["displayText"]?.ToString()) into a variable and use it in both lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done!

Assert.Contains("Man must explore, and this is exploration at its greatest", jsonArray.Select(node => node["displayText"]?.ToString()));
}
}
}