Don't Serialize in GetValue<> of Dictionary Extensions #16224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @MikeAlhayek I remember me, @Piedone, and whoever in the "maintenance" channel agreed that we should have a strategy for reviewing and merging PRs. Each author might need approval from at least one of the core team This is not something personal for this PR, your PRs or my PR, but the process need to be improved, @Piedone can we have a discussion in GitHub for his, or that Discord channel is enough? |
|
Let's keep that on Discord. |
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PR #16139 I introduced a change how get get a value from dictionary. This PR removes that logic to prevent new issues
@sebastienros