Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure.Identity 1.11.4 #16286

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Update Azure.Identity 1.11.4 #16286

merged 1 commit into from
Jun 12, 2024

Conversation

@Piedone
Copy link
Member

Piedone commented Jun 11, 2024

I have no idea how to test this. How did you test?

@hishamco
Copy link
Member Author

@Piedone some packages might be hard to test, while introducing #16284 the packages will be updated automatically without testing. I might suggest adding several unit testing for corner cases that uses almost if not all the dependencies

FYI sometimes checking the release notes for the updated package might be enough especially if it's a patch release

@Piedone
Copy link
Member

Piedone commented Jun 12, 2024

We still need to test them, even if they're hard to test. I don't understand why this is something that we keep getting back to, or why is it controversial, to begin with, that if you change the code, you should also run it and test it. How can you otherwise ensure that you don't break something?

#16284 will only run the package reference updates and open PRs, but we'll still need to test the changes before merging.

@agriffard
Copy link
Member

Previous versions seem to be marked as vulnerable in Nuget packages window in VS:

image

@microposmp
Copy link
Contributor

Currently all builds are failing because of this package. Warnings are treated as errors.

image

Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the diff with the previous version (did you also do this, Hisham?) and I think there's nothing risky there. So, I'm reluctantly merging this, but going forward, we have to find a way to test every change (and I feel that I'm overstating something really obvious). See: #15800.

I'll also look into keeping these warnings as warnings for future such cases.

@Piedone Piedone merged commit e276d7a into main Jun 12, 2024
12 checks passed
@Piedone Piedone deleted the hishamco/azure-identity branch June 12, 2024 18:30
microposmp pushed a commit to microposmp/OrchardCore that referenced this pull request Jun 13, 2024
sebastienros pushed a commit that referenced this pull request Jun 13, 2024
#16274)

* Saving workflow fails

* Fix solution build file references (#16269)

* Remove Gitter references (#16270)

* Add serialisation compatibility of TimeSpan and DateTime  (#16205)

Co-authored-by: Mike Alhayek <[email protected]>
Co-authored-by: Hisham Bin Ateya <[email protected]>

* Update Azure.Identity 1.11.4 (#16286)

* Add rounding.

---------

Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Tony Han <[email protected]>
Co-authored-by: Mike Alhayek <[email protected]>
Co-authored-by: Hisham Bin Ateya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants