-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Azure.Identity 1.11.4 #16286
Update Azure.Identity 1.11.4 #16286
Conversation
I have no idea how to test this. How did you test? |
@Piedone some packages might be hard to test, while introducing #16284 the packages will be updated automatically without testing. I might suggest adding several unit testing for corner cases that uses almost if not all the dependencies FYI sometimes checking the release notes for the updated package might be enough especially if it's a patch release |
We still need to test them, even if they're hard to test. I don't understand why this is something that we keep getting back to, or why is it controversial, to begin with, that if you change the code, you should also run it and test it. How can you otherwise ensure that you don't break something? #16284 will only run the package reference updates and open PRs, but we'll still need to test the changes before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked out the diff with the previous version (did you also do this, Hisham?) and I think there's nothing risky there. So, I'm reluctantly merging this, but going forward, we have to find a way to test every change (and I feel that I'm overstating something really obvious). See: #15800.
I'll also look into keeping these warnings as warnings for future such cases.
#16274) * Saving workflow fails * Fix solution build file references (#16269) * Remove Gitter references (#16270) * Add serialisation compatibility of TimeSpan and DateTime (#16205) Co-authored-by: Mike Alhayek <[email protected]> Co-authored-by: Hisham Bin Ateya <[email protected]> * Update Azure.Identity 1.11.4 (#16286) * Add rounding. --------- Co-authored-by: Zoltán Lehóczky <[email protected]> Co-authored-by: Tony Han <[email protected]> Co-authored-by: Mike Alhayek <[email protected]> Co-authored-by: Hisham Bin Ateya <[email protected]>
https://www.nuget.org/packages/Azure.Identity/1.11.4
https://github.com/Azure/azure-sdk-for-net/releases/tag/Azure.Identity_1.11.4