Adds an overload to RegisterBeforeDispose() #16322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at the end of the list.
gvkries
changed the title
Piedone
requested changes
Jun 14, 2024
| internal void BeforeDispose(Func<ShellScope, Task> callback) => (_beforeDispose ??= []).Insert(0, callback); | ||
| internal void BeforeDispose(Func<ShellScope, Task> callback, bool last) | ||
| { | ||
| var list = _beforeDispose ??= []; |
There was a problem hiding this comment.
Better than a separate collection like I suggested.
Why the new local list though? and not just use _beforeDispose directly.
There was a problem hiding this comment.
Just personal habit...
|
Nice, that will do the trick thanks. |
hishamco
requested changes
Jun 16, 2024
src/OrchardCore/OrchardCore.Abstractions/Shell/Scope/ShellScopeExtensions.cs
Show resolved
Hide resolved
…eExtensions.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
Piedone
approved these changes
Jun 17, 2024
|
Anybody with any further remarks? |
sebastienros
approved these changes
Jun 17, 2024
|
What about this comment? |
|
@hishamco it's about style ... already spent too much time just asking the question ;) |
hishamco
approved these changes
Jun 17, 2024
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an overload to RegisterBeforeDispose() to allow adding callbacks at the end of the list.
Fixes #16306