Make ResourcesTagHelper extensible #16329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please get back to this first? #14867 |
hishamco
reviewed
Jun 17, 2024
src/OrchardCore.Modules/OrchardCore.Resources/Services/ResourcesTagHelperProcessor.cs
Show resolved
Hide resolved
hishamco
requested changes
Jun 17, 2024
Co-authored-by: Hisham Bin Ateya <[email protected]>
This was referenced Jul 1, 2024
hishamco
requested changes
Jul 21, 2024
src/OrchardCore/OrchardCore.ResourceManagement.Abstractions/ResourceTagType.cs
Show resolved
Hide resolved
...rchardCore/OrchardCore.ResourceManagement.Abstractions/ResourcesTagHelperProcessorContext.cs
Show resolved
Hide resolved
...rchardCore/OrchardCore.ResourceManagement.Abstractions/ResourcesTagHelperProcessorContext.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ResourcesTagHelper.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ResourcesTagHelper.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ResourcesTagHelper.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Hisham Bin Ateya <[email protected]>
hishamco
requested changes
Jul 21, 2024
src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ResourcesTag.cs
Outdated
Show resolved
Hide resolved
hishamco
requested changes
Jul 21, 2024
src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ResourcesTagHelper.cs
Outdated
Show resolved
Hide resolved
…urcesTagHelper.cs
hishamco
requested changes
Jul 21, 2024
src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ResourcesTagHelper.cs
Outdated
Show resolved
Hide resolved
…urcesTagHelper.cs
|
Editing from within GitHub is annoying sometimes :) |
hishamco
approved these changes
Jul 24, 2024
src/OrchardCore.Modules/OrchardCore.Resources/Services/ResourcesTagHelperProcessor.cs
Outdated
Show resolved
Hide resolved
|
Anyone else has a comments for this or shall we merge? |
…esTagHelperProcessor.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
|
@Piedone do you have anything to add or shall I merge? |
|
I'm OK with it if you are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also merged overlapping duplicate code for the resources cshtml tag helper and Liquid filter.
Fixes #16033