Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable autocomplete for password fields #16544

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Disable autocomplete for password fields #16544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f25f59e
Disable autocomplete for username and password fields
MikeAlhayek Aug 8, 2024
98f14f6
Merge branch 'main' into ma/autocomplete
MikeAlhayek Aug 8, 2024
2ad4982
more fields
MikeAlhayek Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/OrchardCore.Modules/OrchardCore.Setup/Views/Setup/Index.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@
<div class="mb-3 col-md-6" asp-validation-class-for="Password">
<label asp-for="Password" class="form-label">@T["Password"]</label>
<div class="input-group">
<input asp-for="Password" class="form-control" data-bs-toggle="popover" data-bs-placement="top" data-trigger="focus" data-title="@T["Password strength"]" data-bs-content="@passwordTooltip" required pattern="@passwordRegex" />
<input asp-for="Password" class="form-control" autocomplete="new-password" data-bs-toggle="popover" data-bs-placement="top" data-trigger="focus" data-title="@T["Password strength"]" data-bs-content="@passwordTooltip" required pattern="@passwordRegex" />
<button tabindex="-1" class="btn btn-secondary" type="button" id="togglePassword"><i class="icon fa fa-eye"></i></button>
</div>
<div id="passwordStrength"></div>
Expand All @@ -233,7 +233,7 @@
<div class="mb-3 col-md-6" asp-validation-class-for="PasswordConfirmation">
<label asp-for="PasswordConfirmation" class="form-label">@T["Password Confirmation"]</label>
<div class="input-group">
<input asp-for="PasswordConfirmation" class="form-control" title="@passwordTooltip" required pattern="@passwordRegex" />
<input asp-for="PasswordConfirmation" class="form-control" autocomplete="new-password" title="@passwordTooltip" required pattern="@passwordRegex" />
<button tabindex="-1" class="btn btn-secondary" type="button" id="togglePasswordConfirmation"><i class="icon fa fa-eye"></i></button>
</div>
<span asp-validation-for="PasswordConfirmation" class="text-danger"></span>
Expand Down
4 changes: 2 additions & 2 deletions src/OrchardCore.Modules/OrchardCore.Users/Views/Account/ChangePassword.cshtml
View file
Open in desktop
Piedone marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
<div class="mb-3">
<label asp-for="CurrentPassword" class="col-md-4 form-label">@T["Current password"]</label>
<div class="col-md-8">
<input asp-for="CurrentPassword" class="form-control" autofocus />
<input asp-for="CurrentPassword" class="form-control" autofocus autocomplete="new-password" />
<span asp-validation-for="CurrentPassword" class="text-danger"></span>
</div>
</div>
<div class="mb-3">
<label asp-for="Password" class="col-md-4 form-label">@T["New password"]</label>
<div class="col-md-8">
<input asp-for="Password" class="form-control" />
<input asp-for="Password" class="form-control" autocomplete="new-password" />
<div id="passwordStrength"></div>
<span asp-validation-for="Password" class="text-danger"></span>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/OrchardCore.Modules/OrchardCore.Users/Views/RegisterUserFormIdentifier.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@

<div class="mb-3">
<label asp-for="Password" class="form-label">@T["Password"]</label>
<input asp-for="Password" class="form-control" />
<input asp-for="Password" class="form-control" autocomplete="new-password" />
<span asp-validation-for="Password" class="text-danger"></span>
</div>

<div class="mb-3">
<label asp-for="ConfirmPassword" class="form-label">@T["Confirm password"]</label>
<input asp-for="ConfirmPassword" class="form-control" />
<input asp-for="ConfirmPassword" class="form-control" autocomplete="new-password" />
<span asp-validation-for="ConfirmPassword" class="text-danger"></span>
</div>
4 changes: 2 additions & 2 deletions src/OrchardCore.Modules/OrchardCore.Users/Views/ResetPasswordFormIdentifier.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@

<div class="mb-3">
<label asp-for="NewPassword" class="form-label">@T["New password"]</label>
<input asp-for="NewPassword" class="form-control" />
<input asp-for="NewPassword" class="form-control" autocomplete="new-password" />
<div id="passwordStrength"></div>
<span asp-validation-for="NewPassword" class="text-danger"></span>
</div>

<div class="mb-3">
<label asp-for="PasswordConfirmation" class="form-label">@T["New password confirmation"]</label>
<input asp-for="PasswordConfirmation" class="form-control" />
<input asp-for="PasswordConfirmation" class="form-control" autocomplete="new-password" />
<span asp-validation-for="PasswordConfirmation" class="text-danger"></span>
</div>
4 changes: 2 additions & 2 deletions src/OrchardCore.Modules/OrchardCore.Users/Views/UserFields.Edit.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<label asp-for="Password" class="form-label">@T["Password"]</label>
<div class="input-group col-md-4">
<span class="input-group-text password-toggle-button"><span class="toggle-icon fas fa-eye prefix"></span></span>
<input asp-for="Password" type="password" class="form-control password-input-field" placeholder="@T["Password"]" />
<input asp-for="Password" type="password" class="form-control password-input-field" placeholder="@T["Password"]" autocomplete="new-password" />
<span asp-validation-for="Password" class="text-danger"></span>
</div>
</div>
Expand All @@ -40,7 +40,7 @@
<label asp-for="PasswordConfirmation" class="sr-only">@T["Password Confirmation"]</label>
<div class="input-group col-md-4">
<span class="input-group-text password-confirmation-toggle-button"><span class="toggle-icon fas fa-eye prefix"></span></span>
<input asp-for="PasswordConfirmation" type="password" class="form-control password-confirmation-input-field" placeholder="@T["Password confirmation"]" />
<input asp-for="PasswordConfirmation" type="password" class="form-control password-confirmation-input-field" autocomplete="new-password" placeholder="@T["Password confirmation"]" />
<span asp-validation-for="PasswordConfirmation" class="text-danger"></span>
</div>

Expand Down