Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the description and names of the openId features #16697

Merged
merged 15 commits into from
Sep 11, 2024
Merged

Improve the description and names of the openId features #16697

merged 15 commits into from
Sep 11, 2024

Conversation

MikeAlhayek
Copy link
Member

No description provided.

kevinchalet
kevinchalet reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@kevinchalet kevinchalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upper-casing things like Server or Client isn't necessary (the GUI is not a spec 😄), so it's probably best to avoid it to keep it more readable, IMO.

src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs Outdated Show resolved Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs Outdated Show resolved Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs Outdated Show resolved Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs Outdated Show resolved Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs Outdated Show resolved Hide resolved
src/docs/reference/modules/OpenId/README.md Outdated Show resolved Hide resolved
src/docs/reference/modules/OpenId/README.md Outdated Show resolved Hide resolved
src/docs/reference/modules/OpenId/README.md Outdated Show resolved Hide resolved
@kevinchalet kevinchalet added this to the 2.1 milestone Sep 10, 2024
MikeAlhayek and others added 9 commits September 10, 2024 11:30
@MikeAlhayek
fix name
9337124
@MikeAlhayek @kevinchalet
Update src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs
dc276df 
Co-authored-by: Kévin Chalet <[email protected]>
@MikeAlhayek @kevinchalet
Update src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs
e1e2e0f 
Co-authored-by: Kévin Chalet <[email protected]>
@MikeAlhayek @kevinchalet
Update src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs
bd08b89 
Co-authored-by: Kévin Chalet <[email protected]>
@MikeAlhayek @kevinchalet
Update src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs
333d389 
Co-authored-by: Kévin Chalet <[email protected]>
@MikeAlhayek @kevinchalet
Update src/docs/reference/modules/OpenId/README.md
7aedff3 
Co-authored-by: Kévin Chalet <[email protected]>
@MikeAlhayek @kevinchalet
Update src/docs/reference/modules/OpenId/README.md
30e750d 
Co-authored-by: Kévin Chalet <[email protected]>
@MikeAlhayek @kevinchalet
Update src/docs/reference/modules/OpenId/README.md
20d757e 
Co-authored-by: Kévin Chalet <[email protected]>
@MikeAlhayek
Merge branch 'main' into ma/open-id-descriptions
8fd9794
@MikeAlhayek MikeAlhayek modified the milestones: 2.1, 2.x Sep 10, 2024
kevinchalet
kevinchalet approved these changes Sep 11, 2024
View reviewed changes
src/docs/reference/modules/OpenId/README.md Outdated Show resolved Hide resolved
src/docs/reference/modules/OpenId/README.md Outdated Show resolved Hide resolved
@MikeAlhayek MikeAlhayek enabled auto-merge (squash) September 11, 2024 22:57
@MikeAlhayek MikeAlhayek merged commit 4a42891 into main Sep 11, 2024
7 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/open-id-descriptions branch September 11, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinchalet kevinchalet kevinchalet approved these changes

Assignees
No one assigned
Labels
enhancement OpenId
Projects
None yet
Milestone
2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeAlhayek @kevinchalet