Enhance the Two-Factor Authentication settings #16707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| builder.AppendWhitespace(); | ||
| } | ||
| builder.AppendHtml(H.Plural(hours, "{1} hour", "{1} hours", hours)); |
There was a problem hiding this comment.
You can't concatenate translated strings. It has to be a single one, which is this case doesn't seem possible because of pluralization (days could be one and hours multiple).
The only solution I could think of is to only keep the big part like "{0} days", or "{o} hours" and not concatenate.
There was a problem hiding this comment.
why wouldn't this work? each phrase can be translated separately and then build into html content.
Here is an example
There was a problem hiding this comment.
why wouldn't this work
For one some people write from right to left ;) And pretty sure we can find languages where durations don't work this way too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I also added a new shape called
Durationshape that would convert TimeSpan to human readable string