Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to new up a EmailClient instance on every email message #16746

Merged
merged 1 commit into from
Sep 18, 2024
Merged

No need to new up a EmailClient instance on every email message #16746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/OrchardCore.Modules/OrchardCore.Email.Azure/Services/AzureEmailProviderBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ public abstract class AzureEmailProviderBase : IEmailProvider
private readonly IEmailAddressValidator _emailAddressValidator;
private readonly ILogger _logger;

private EmailClient _emailClient;

protected readonly IStringLocalizer S;

public AzureEmailProviderBase(
Expand Down Expand Up @@ -132,8 +134,9 @@ public virtual async Task<EmailResult> SendAsync(MailMessage message)

try
{
var client = new EmailClient(_providerOptions.ConnectionString);
var emailResult = await client.SendAsync(WaitUntil.Completed, emailMessage);
_emailClient ??= new EmailClient(_providerOptions.ConnectionString);

var emailResult = await _emailClient.SendAsync(WaitUntil.Completed, emailMessage);

if (emailResult.HasValue)
{
Expand Down
Loading