Apply Template pattern for Recipe Steps #16862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
requested changes
Oct 10, 2024
src/OrchardCore/OrchardCore.Recipes.Abstractions/Services/NamedRecipeStepHandler.cs
Show resolved
Hide resolved
hishamco
approved these changes
Oct 10, 2024
|
@MikeAlhayek seems this PR causes a bug that I'm trying to figure out, the step name is sometimes not the same as the class name, that's why PR 16866 has been broken |
|
@hishamco I don't think you meant to reference 16866 |
|
Sorry I mean #16865 |
|
The unit issue in #16865 is not caused by this PR. that one is because the expected settings is not the same as the found settings |
|
I'm checking, hope it's not a unit test bug :) |
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.