-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Attach the DashboardPart to content types with DashboardWidget stereotype #16911
Conversation
I'll review this tomorrow. |
src/OrchardCore/OrchardCore.ContentTypes.Abstractions/Events/IContentDefinitionHandler.cs
Show resolved
Hide resolved
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
src/OrchardCore.Modules/OrchardCore.ContentTypes/Services/ContentDefinitionService.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Settings/ContentSettings.cs
Outdated
Show resolved
Hide resolved
...ore.Modules/OrchardCore.AdminDashboard/Services/DashboardPartContentTypeDefinitionHandler.cs
Outdated
Show resolved
Hide resolved
…/OrchardCore into ma/code-managed-parts
src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.ContentTypes/Services/ContentDefinitionService.cs
Outdated
Show resolved
Hide resolved
Spent some time on the API, For this reason we should have a different handler for these building events. And this will be used in the ContentDefinitionManager only. This may also remove this cyclic service dependency. |
@sebastienros look at this discussion #16911 (comment) I originally did it using a separate interface. but was merged with the existing interface. |
...ore.Modules/OrchardCore.AdminDashboard/Services/DashboardPartContentTypeDefinitionHandler.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Settings/ContentSettings.cs
Show resolved
Hide resolved
...ardCore/OrchardCore.ContentTypes.Abstractions/Events/ContentDefinitionBuildingContextBase.cs
Outdated
Show resolved
Hide resolved
...ore.Modules/OrchardCore.AdminDashboard/Services/DashboardPartContentTypeDefinitionHandler.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Settings/ContentSettings.cs
Outdated
Show resolved
Hide resolved
@sebastienros thing else to add here? @Piedone this is ready for a second review. |
Fix #16547