Fix functional tests #16980
Merged
Fix functional tests #16980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
force-pushed
the
sebros/functests
branch
from
b2d6dd4
to
621e07c
Compare
Piedone
reviewed
Nov 9, 2024
Comment on lines
+21
to
+24
| if (!alternateElement.AsSpan().ContainsAny(AlternateChars)) | ||
| { | ||
| return alternateElement; | ||
| } |
There was a problem hiding this comment.
How does this fix an exception? Or is this condition just for perf?
There was a problem hiding this comment.
Right, it's unrelated, just trying to squeeze some perf. Also an opportunity to raise awareness about SeachValues.
Piedone
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw some exceptions in the functional tests logs. Since these are from event handlers they were not interfering with the page rendering and hence not triggering a test failure. We may want to check if the logs contain and exception to trigger function test failures.