Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Nest package with Elastic.Clients.Elasticsearch #17027

Merged
merged 29 commits into from
Nov 26, 2024
Merged

Replace Nest package with Elastic.Clients.Elasticsearch #17027

merged 29 commits into from
Nov 26, 2024

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Nov 15, 2024 •
edited
Loading

Fix #17021
Fix #15977

The code was converted but was not yet tested

@MikeAlhayek MikeAlhayek marked this pull request as ready for review November 15, 2024 22:14
@MikeAlhayek MikeAlhayek mentioned this pull request Nov 15, 2024
Closed
@sebastienros
Copy link
Member

You have 2 hours to get GraphQL 8.0 now. Go!

@MikeAlhayek
Copy link
Member Author

You have 2 hours to get GraphQL 8.0 now. Go!

I am leaving that one for you to have fun with. Can't have all the fun by myself.

@hishamco
Copy link
Member

If no one want to have fun with GraphQL, I might have a fun with it :)

@MikeAlhayek
Copy link
Member Author

@hishamco if you have time, it would be great. There is a draft PR that you can continue.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@MikeAlhayek MikeAlhayek mentioned this pull request Nov 22, 2024
Closed
@MikeAlhayek MikeAlhayek added this to the 3.0 milestone Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@MikeAlhayek
Merge remote-tracking branch 'origin/main' into ma/elasticsearch-8
04fc42d 
# Conflicts:
#	mkdocs.yml
#	src/OrchardCore.Modules/OrchardCore.Search.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs
#	src/docs/releases/3.0.0.md
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@MikeAlhayek
Copy link
Member Author

@denispetrische I added a fix for the NRE you had. If you encounter any issue, please provide me step by step instruction on how to reproduce.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@MikeAlhayek
Merge remote-tracking branch 'origin/main' into ma/elasticsearch-8
2e9a9d0 
# Conflicts:
#	src/OrchardCore.Modules/OrchardCore.Search.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs
@MikeAlhayek MikeAlhayek merged commit 26a6ede into main Nov 26, 2024
8 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/elasticsearch-8 branch November 26, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros Awaiting requested review from sebastienros

@Skrypt Skrypt Awaiting requested review from Skrypt

Assignees
No one assigned
Labels
Elasticsearch
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Replace Nest package with Elastic.Clients.Elasticsearch Deprecated packages
3 participants
@MikeAlhayek @sebastienros @hishamco