Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple the OpenID module from the Users/Roles modules #1786

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Decouple the OpenID module from the Users/Roles modules #1786

merged 1 commit into from
Nov 21, 2018

Conversation

kevinchalet
Copy link
Member

@kevinchalet kevinchalet commented May 11, 2018 •
edited
Loading

Related topic: #1023

@kevinchalet kevinchalet added this to the beta2 milestone May 11, 2018
@kevinchalet kevinchalet self-assigned this May 11, 2018
@kevinchalet kevinchalet mentioned this pull request May 11, 2018
Closed
@kevinchalet kevinchalet modified the milestones: beta2, rc Jun 3, 2018
@MichaelPetrinolis MichaelPetrinolis mentioned this pull request Oct 30, 2018
Merged
@kevinchalet kevinchalet mentioned this pull request Nov 6, 2018
Closed
@kevinchalet
Copy link
Member Author

Rebased.

@sebastienros
Copy link
Member

Is the "notready" tag still appropriate?

@kevinchalet
Copy link
Member Author

@sebastienros we should have a chat about the userinfo changes, as claims are now retrieved from the access token instead of the database (previously, we used to rely on UserManager for that).

@petedavis petedavis mentioned this pull request Nov 7, 2018
Closed
@kevinchalet kevinchalet modified the milestones: rc, beta3 Nov 21, 2018
@kevinchalet kevinchalet merged commit 0f11c3c into OrchardCMS:dev Nov 21, 2018
@kevinchalet kevinchalet deleted the openid branch November 21, 2018 14:17
@kevinchalet
Copy link
Member Author

@sebastienros thanks for the review!

@sebastienros
Copy link
Member

yolo

@kevinchalet kevinchalet mentioned this pull request Dec 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

@jersiovic jersiovic Awaiting requested review from jersiovic

@alexbocharov alexbocharov Awaiting requested review from alexbocharov

Assignees

@kevinchalet kevinchalet

Labels
enhancement OpenId
Projects
None yet
Milestone
beta3
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinchalet @sebastienros