New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents a deferred task lambda from holding a ref on a scoped service. #4729

Merged

sebastienros merged 1 commit into dev from jtkech/indexing

Nov 4, 2019

Member

jtkech commented Nov 3, 2019

This by using a local variable in place of using a field of the scoped service

I did it in IndexingTaskManager the only place where there is this use case.

Then i also removed the lock on _tasksQueue because it is hold by a scoped service.

Already integrated in #4001.


          Prevents a deferred task lambda from holding a ref on a scoped service.

47f39e6

sebastienros merged commit edad8c2 into dev

sebastienros deleted the jtkech/indexing branch

November 4, 2019 22:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet