Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PoExtractor & PoExtractor.OrchardCore into a single tool #64

Closed
hishamco opened this issue Nov 18, 2022 · 2 comments · Fixed by #65
Closed

Merge PoExtractor & PoExtractor.OrchardCore into a single tool #64

hishamco opened this issue Nov 18, 2022 · 2 comments · Fixed by #65

Comments

@hishamco
Copy link
Member

Now we have two tools which do the same things except PoExtractor.OrchardCore extend the first one by supporting liquid, while the intend of PoExtractor to extract translatable strings in Orchard Core, single tool is enough. We might extend this tool by having options to skip certain template

/cc @Skrypt

@lukaskabrt
Copy link
Collaborator

Just some notes from the history ...

  • There used to be --liquid switch, but it was removed in Fixes issues with latest OC build #34
  • Original idea behind two separate tools was not to force other consumers of the tool to take dependency on Orchard Core

@hishamco
Copy link
Member Author

Thanks for your input @lukaskabrt

Original idea behind two separate tools was not to force other consumers of the tool to take dependency on Orchard Core

I expect that but while we are using the OC localization identifier conventions it doesn't make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants