Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null reference exception when extracting plural strings #73

Merged

Conversation

rjpowers10
Copy link

Fixes #72

@hishamco
Copy link
Member

@hishamco
Copy link
Member

I did it from my side, just review the changes, let me know if they looks good to you

@rjpowers10
Copy link
Author

Nice! I like the changes you made to the tests. Much better than what I had!

@hishamco hishamco merged commit cee3f96 into OrchardCoreContrib:master Jan 23, 2023
@hishamco
Copy link
Member

Thanks for your contribution @rjpowers10, one more thing is there anything else we might need to add, coz I'd like to ship a patch release 1.0.1

@rjpowers10
Copy link
Author

Thanks for your contribution @rjpowers10, one more thing is there anything else we might need to add, coz I'd like to ship a patch release 1.0.1

At this moment, no, I think this is good for now.

@rjpowers10 rjpowers10 deleted the FixPluralStringExtractor branch January 24, 2023 14:14
@hishamco
Copy link
Member

FYI https://www.nuget.org/packages/OrchardCoreContrib.PoExtractor/1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extractor throws exception on uses of T.Plural
2 participants