-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix null reference exception when extracting plural strings #73
Fix null reference exception when extracting plural strings #73
Conversation
test/OrchardCoreContrib.PoExtractor.Tests/OrchardCoreContrib.PoExtractor.Tests.csproj
Outdated
Show resolved
Hide resolved
test/OrchardCoreContrib.PoExtractor.Tests/Fakes/FakeStringLocalizer.cs
Outdated
Show resolved
Hide resolved
Could you please rebase on this branch https://github.com/OrchardCoreContrib/OrchardCoreContrib.PoExtractor/tree/FixPluralStringExtractor |
I did it from my side, just review the changes, let me know if they looks good to you |
Nice! I like the changes you made to the tests. Much better than what I had! |
Thanks for your contribution @rjpowers10, one more thing is there anything else we might need to add, coz I'd like to ship a patch release |
At this moment, no, I think this is good for now. |
Fixes #72