From 65e383997d91542ae6453e3813534d0596a845a2 Mon Sep 17 00:00:00 2001 From: chiddy Date: Mon, 13 Dec 2021 14:36:00 +1000 Subject: [PATCH] Apply suggestion from KingOfSquares here's hoping the "commit suggestion" button doesn't screw me over Co-authored-by: KingOfSquares <19822231+KingOfSquares@users.noreply.github.com> Signed-off-by: chiddy --- core/src/main/java/tc/oc/pgm/filters/FilterParser.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/core/src/main/java/tc/oc/pgm/filters/FilterParser.java b/core/src/main/java/tc/oc/pgm/filters/FilterParser.java index 7e6d3c83df..3fbb07d6b5 100644 --- a/core/src/main/java/tc/oc/pgm/filters/FilterParser.java +++ b/core/src/main/java/tc/oc/pgm/filters/FilterParser.java @@ -432,13 +432,7 @@ public GoalFilter parseCaptured(Element el) throws InvalidXMLException { this.factory.getFeatures().createReference(new Node(el), GoalDefinition.class); Attribute attrTeam = el.getAttribute("team"); - XMLFeatureReference team; - if (attrTeam != null) { - team = this.factory.getFeatures().createReference(new Node(attrTeam), TeamFactory.class); - - } else { - team = null; - } + XMLFeatureReference team = attrTeam != null ? this.factory.getFeatures().createReference(new Node(attrTeam), TeamFactory.class) : null; return new GoalFilter(goal, team, false); }