Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a chest GUI for player settings #217

Closed
Meeples10 opened this issue Jan 10, 2020 · 7 comments
Closed

Add a chest GUI for player settings #217

Meeples10 opened this issue Jan 10, 2020 · 7 comments
Labels
feature New feature or request

Comments

@Meeples10
Copy link
Contributor

This could help players see what settings are available and allow them to easily change settings by clicking, rather than typing commands.

@Brottweiler Brottweiler added the feature New feature or request label Jan 10, 2020
@KingOfSquares
Copy link
Contributor

Im thinking of the following implementation:

  • Make a new MatchModule SettingsGuiMatchModule or some other name

  • Have a method listen for a InventoryClickEvent on a specific item while in obs (Maybe a sheet of paper)

  • When the item is clicked, create a new GUI with Bukkit#createInventory with items representing each setting, open that GUI with event#getPlayer#openInventory and on each item hover it should display what setting it is and if it is SHOWN or HIDDEN/ ACTIVATED or NOT ACTIVE and so on

  • The method will check the players settings with getSettings to decide which values it will put in the lore of each item in the GUI.

  • Have another method listening for a InventoryClickEvent on each item in the GUI and then toggle that setting by sending a /toggle .

  • Unsure if all items in the GUI should be the same item to limit which types of InventoryClickEvent we need to listen for, or if each setting should have their own item that corresponds to the type of setting it represents (Sounds -> Noteblock etc..)

Maybe kinda messy? Hope you get my thoughts. I will wait making this until somebody can tell me if it's the right way to go hehe.

@Pablete1234
Copy link
Member

@KingOfSquares Look at the current implementation of observer tools. Some of the tools there (like obs visibility) are literally changing a setting.

The idea is, this should be a menu with all relevant settings

@KingOfSquares
Copy link
Contributor

This, as in the pre-existing observer tools? Do we just expand on that? Or make a new GUI for all settings, i don't understand.

@Pablete1234
Copy link
Member

Observer tools can be used as reference on how you could implement the gui. it would be a different menu

@Brottweiler
Copy link
Collaborator

Not sure if this is related or should be in it's own issue, but a GUI for reporting would be nice as well. Most servers today don't allow you to write your own report message. Having a GUI would totally remove joke reports too, but the false reports would not go down.

You would just type /report <player> and a GUI will show up. You configure in the config what block or item should show and what the reason would be. So a diamond sword could be hacking. A TNT block would be team griefing etc.

@rafibaum rafibaum self-assigned this May 7, 2020
@rafibaum
Copy link

rafibaum commented May 7, 2020

Added in #451

@Pablete1234
Copy link
Member

closed by #916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Development

Successfully merging a pull request may close this issue.

5 participants