Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cause filter does not work for trample #796

Closed
PabloPintor opened this issue Feb 5, 2021 · 0 comments · Fixed by #1086
Closed

Cause filter does not work for trample #796

PabloPintor opened this issue Feb 5, 2021 · 0 comments · Fixed by #1086
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@PabloPintor
Copy link
Contributor

Event for block trampling generates an event that cannot be filtered with the cause filter, because GeneralizingEvent always gets the original cause (like PlayerCoarseMoveEvent).

https://github.com/PGMDev/PGM/blob/dev/core/src/main/java/tc/oc/pgm/filters/CauseFilter.java#L79
https://github.com/PGMDev/PGM/blob/dev/core/src/main/java/tc/oc/pgm/filters/CauseFilter.java#L122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Trample in Cause Filter CoWinkKeyDinkInc/PGM
2 participants
@Pablete1234 @PabloPintor