Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add several enhancments to map voting, including book gui #193

Merged
merged 5 commits into from
Jan 5, 2020
Merged

Add several enhancments to map voting, including book gui #193

merged 5 commits into from
Jan 5, 2020

Conversation

Pablete1234
Copy link
Member

@Pablete1234 Pablete1234 commented Jan 5, 2020 •
edited
Loading

From the things in #169 :

  • Added book GUI (opens 5s after match end)
  • The next map is no longer shown before the actual cycle
  • The book gui informs you about multi-map voting, it also keeps re-opening the book as you vote until you close.
  • You can see the map scores with -s (score) on /pool
  • Map scoring is now linear instead of exponential towards default score. This means map scores will be generally slower to get more/less significant over time, and way less likely to re-appear on a vote after they've played
  • Book GUI shows map tags on hover, should be helpful if you don't know the map.

@Pablete1234 Pablete1234 requested a review from Electroid as a code owner January 5, 2020 05:41
Electroid
Electroid approved these changes Jan 5, 2020
View reviewed changes
Copy link
Member

@Electroid Electroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looking forward to that book! Just a small nit.

src/main/i18n/templates/strings.properties Outdated
@@ -546,7 +546,8 @@ command.pools.mapPoolList.title = Loaded Map Pools
command.pools.skip.message = Skipped a total of {0} positions.
command.pools.skip.noNegative = You may not skip negative positions!

command.pool.vote.hover = Click to toggle vote
command.pool.vote.book.title = Map Vote
command.pool.vote.book.header = Click to select all maps you'd like to play:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For translations avoid contractions: you would like

@Pablete1234 Pablete1234 merged commit a025455 into master Jan 5, 2020
@Pablete1234 Pablete1234 deleted the vote-enhancements branch January 5, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electroid Electroid Electroid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pablete1234 @Electroid