-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add <gamemode> module #873
Merged
+104
−6
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
156d67c
Add <gamemode> module
CoWinkKeyDinkInc 7ad6fe0
Reformat code
CoWinkKeyDinkInc f77bb7a
Add more gamemode IDs for <gamemode> module
CoWinkKeyDinkInc ea38bb8
Move gamemode parsing to MapInfoImpl, start on MapTag parsing
CoWinkKeyDinkInc c918319
Create Gamemode enum, allow multiple gamemode tags
CoWinkKeyDinkInc 99ddde4
remove name and mapTag from Gamemode eneum, fix MapInfo API
CoWinkKeyDinkInc d9d24db
Improve gamemode parsing
CoWinkKeyDinkInc 558b277
Make gamemode displaying on Sidebar more flexible
CoWinkKeyDinkInc a4db68e
Merge branch 'dev' into add-gamemode-tag
CoWinkKeyDinkInc d72004f
Merge branch 'dev' into add-gamemode-tag
CoWinkKeyDinkInc bdfc505
Fix merge conflict
CoWinkKeyDinkInc 6c21c1c
Implement suggestions
CoWinkKeyDinkInc 3f141de
Merge remote-tracking branch 'upstream/dev' into add-gamemode-tag
CoWinkKeyDinkInc 98b8af6
Use TextFormatter to parse gamemode title
CoWinkKeyDinkInc 98fc003
Update definition in MapInfo.java
CoWinkKeyDinkInc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
package tc.oc.pgm.api.map; | ||
|
||
public enum Gamemode { | ||
ATTACK_DEFEND("ad"), | ||
ARCADE("arcade"), | ||
BLITZ("blitz"), | ||
BLITZ_RAGE("br"), | ||
CAPTURE_THE_FLAG("ctf"), | ||
CONTROL_THE_POINT("cp"), | ||
CAPTURE_THE_WOOL("ctw"), | ||
DESTROY_THE_CORE("dtc"), | ||
DESTROY_THE_MONUMENT("dtm"), | ||
FREE_FOR_ALL("ffa"), | ||
FLAG_FOOTBALL("ffb"), | ||
KING_OF_THE_HILL("koth"), | ||
KING_OF_THE_FLAG("kotf"), | ||
MIXED("mixed"), | ||
RAGE("rage"), | ||
RACE_FOR_WOOL("rfw"), | ||
SCOREBOX("scorebox"), | ||
DEATHMATCH("tdm"); | ||
|
||
private final String id; | ||
|
||
Gamemode(String id) { | ||
this.id = id; | ||
} | ||
|
||
public static Gamemode byId(String gamemodeId) { | ||
for (Gamemode gamemode : Gamemode.values()) { | ||
if (gamemode.getId().equals(gamemodeId)) { | ||
return gamemode; | ||
} | ||
} | ||
return null; | ||
} | ||
|
||
public String getId() { | ||
return id; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't lie in the javadocs, makes the APIs hard to use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look resolved