Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorts in the video page #981

Closed
Jinsgo opened this issue Apr 30, 2024 · 4 comments
Closed

Shorts in the video page #981

Jinsgo opened this issue Apr 30, 2024 · 4 comments
Labels
Milestone

Comments

@Jinsgo
Copy link

Jinsgo commented Apr 30, 2024

Hello. Congratulations on your extension, it's working really well!

I noticed that the site had a section dedicated to shorts. I was wondering if it was also possible to remove the shorts suggestions from the video page (framed in red on the screenshot).
Capture d'écran 2024-04-30 125209

It seems that the code that manages this carousel is this:
Capture d'écran 2024-04-30 125628

Thanks for your work!

@ParticleCore
Copy link
Owner

Hi, sure thing, I actually planned on doing that from the start and completely forgot. Will address it in the next version update.

@ParticleCore ParticleCore added this to the 2.1.1 milestone Apr 30, 2024
@Jinsgo
Copy link
Author

Jinsgo commented Apr 30, 2024

Great! Thanks again 👍

@ParticleCore
Copy link
Owner

Will tie this up after #994 because I want to fix things up before adding more

@ParticleCore
Copy link
Owner

Feature seems to be working well, I've bundled it with the other settings that already existed, but was unsure if it made more sense to put it in the video page settings, but for now it will stay like this.

Here's an example showing the video page with the setting enabled (show shorts), disabled (don't show shorts), and then enabled again. Each time the setting was changed, the page was refreshed.

1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants