-
Notifications
You must be signed in to change notification settings - Fork 301
/
ReferenceVersions.cs
92 lines (81 loc) · 3.27 KB
/
ReferenceVersions.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
using System;
using System.Linq;
using System.Xml;
using System.Xml.Linq;
using System.Xml.XPath;
using NUnit.Framework;
namespace IntegrityTests
{
public class ReferenceVersions
{
[Test]
public void MustScopeReferencesToAMajorVersion()
{
new TestRunner("*.csproj",
"Package References cannot have Version=\"*\" or restore will sometimes fail and yield old, incorrect, or mismatched versions.")
.Run(projectFilePath =>
{
XDocument xdoc = default;
try
{
xdoc = XDocument.Load(projectFilePath);
}
catch
{
return false;
}
var nsMgr = new XmlNamespaceManager(new NameTable());
var query = "/Project/ItemGroup/PackageReference[@Version='*']";
var xmlnsAtt = xdoc.Root.Attribute("xmlns");
if (xmlnsAtt != null)
{
query = "/x:Project/x:ItemGroup/x:PackageReference[@Version='*']";
var xmlns = xmlnsAtt.Value;
nsMgr.AddNamespace("x", xmlns);
}
var badPackageRefs = xdoc.XPathSelectElements(query, nsMgr);
return !badPackageRefs.Any();
});
}
[Test]
public void MustNotUseNugetRangedVersions()
{
new TestRunner("*.csproj", "Package References cannot have ranged versions as restore will sometimes fail and yield old, incorrect, or mismatched versions.")
.Run(projectFilePath =>
{
XDocument xdoc = default;
try
{
xdoc = XDocument.Load(projectFilePath);
}
catch
{
Console.WriteLine($"WARN: Could not parse the .csproj file at: '{projectFilePath}'");
return true;
}
var nsMgr = new XmlNamespaceManager(new NameTable());
var versionQuery = "/Project/ItemGroup/PackageReference[@Version]";
var xmlnsAtt = xdoc.Root.Attribute("xmlns");
if (xmlnsAtt != null)
{
versionQuery = "/x:Project/x:ItemGroup/x:PackageReference[@Version]";
var xmlns = xmlnsAtt.Value;
nsMgr.AddNamespace("x", xmlns);
}
var packageRefs = xdoc.XPathSelectElements(versionQuery, nsMgr).ToList();
foreach (var reference in packageRefs)
{
var version = reference.Attribute("Version").Value;
if (version.Contains('[') ||
version.Contains('(') ||
version.Contains(')') ||
version.Contains(']'))
{
return false;
}
}
return true;
});
}
}
}