Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Arm 1" as "Y" option in the Relation module #397

Open
kchall opened this issue Feb 4, 2025 · 1 comment
Open

Add "Arm 1" as "Y" option in the Relation module #397

kchall opened this issue Feb 4, 2025 · 1 comment
Assignees
@kvesik
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kchall
Copy link
Member

kchall commented Feb 4, 2025

We should add "Arm 1" as an option under the "Y" selections for the Relation module:

Image

Originally, I didn't think we needed to include it, because H1 can't very easily be on Arm1, and if H2 is on Arm1, you could select that by having Arm1 be X and H2 be Y. But now that I'm thinking about the alignment algorithm for Relation modules, we should go ahead and have Arm1 here as an option as well.
@kchall kchall added enhancement New feature or request good first issue Good for newcomers labels Feb 4, 2025
@kvesik kvesik assigned kvesik and unassigned kvesik Feb 4, 2025
@kchall
Copy link
Member Author

kchall commented Feb 6, 2025

@kvesik Hmm, it also occurs to me (now, of course!) that we should allow "Both Arms" and "Both Legs" as options in both X and Y. Sorry and thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvesik kvesik

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/397-add-arm-1-as-y-option-in-the-relation-module PhonologicalCorpusTools/SLPAA
2 participants
@kchall @kvesik