Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing McDonald's Collection 2021 #183

Closed
pedrommcarrasco opened this issue Mar 15, 2021 · 8 comments
Closed

Missing McDonald's Collection 2021 #183

pedrommcarrasco opened this issue Mar 15, 2021 · 8 comments

Comments

@pedrommcarrasco
Copy link
Contributor

pedrommcarrasco commented Mar 15, 2021

t looks like we're missing the latest McDonald's Collection)

How can I help you with it @adback03, is your tool not able to fetch these?

@MatiasOETamminen
Copy link
Contributor

We're also missing MCD 2013, 14, 15, 17, and 18

@adback03
Copy link
Member

My sources do not have these sets...I'll probably have to add them manually. I'm open to help on this one if anyone has time!

@MatiasOETamminen
Copy link
Contributor

My sources do not have these sets...I'll probably have to add them manually. I'm open to help on this one if anyone has time!

I can try to help, although only with the jsons. Pictures have to be sourced elsewhere. As a proof of concept for myself, I tried adding MCD 2014 at #186. I hope it's alright.

@MatiasOETamminen
Copy link
Contributor

Also, MCD 2013 was only ever released in French, so that calls for policy questions. In addition the English and French sets of MCD 2018 & 2019 contain different cards and different number of cards. The French MCD2018 even has it's own, unique symbol.

@pedrommcarrasco
Copy link
Contributor Author

Also, MCD 2013 was only ever released in French, so that calls for policy questions. In addition the English and French sets of MCD 2018 & 2019 contain different cards and different number of cards. The French MCD2018 even has it's own, unique symbol.

I would personally focus on English sets only for now 🤔

@mycrickets
Copy link
Contributor

#219

@MatiasOETamminen
Copy link
Contributor

This should be closed, as it is resolved.

@adback03
Copy link
Member

Missed closing this one. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants