Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure event.target is the real addons target #691

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christophe-g
Copy link

We want the real addons target to be added as addons.

Due to shadowDom event retargeting, event.target is is not the addon anymore in some advanced templating scenario. As a result, updateAddons call a not-existing update method, creating an error.

This PR makes sure we add the initial event target.

This PR is against the 2.x branch (which I use), but the observed error is expected to happen under 3.x as well.

@e111077
Copy link
Contributor

e111077 commented Mar 4, 2019

Unfortunately we are still doing a large internal migration that may result in an external major release of paper-input. We are in a code freeze for the element and iron-input in the meanwhile.

@e111077 e111077 added the v4 label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants