Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for HTML5 datalists #86

Merged
merged 1 commit into from
Jun 19, 2015

Conversation

RNCRyan
Copy link
Contributor

@RNCRyan RNCRyan commented Jun 12, 2015

Added support for HTML5 datalists. This pull persists a list property as an attribute to the iron-input input element.

@RNCRyan
Copy link
Contributor Author

RNCRyan commented Jun 12, 2015

Huzzah; I believe I've finally pleased the googlebot checks.

Sorry for the pull request spam; I couldn't figure out how to fix an existing pull request, and so I just closed/remade whenever I tried a fix to my PR submission. Submitting to GitHub is new to me...

@RNCRyan
Copy link
Contributor Author

RNCRyan commented Jun 16, 2015

@morethanreal Any chance I could get this request merged? Or is there anything I can do to make this PR more appropriate to be merge material? Thanks.

@morethanreal
Copy link
Contributor

lgtm

morethanreal pushed a commit that referenced this pull request Jun 19, 2015
Added support for HTML5 datalists
@morethanreal morethanreal merged commit 37afce7 into PolymerElements:master Jun 19, 2015
@KeithHenry
Copy link

This only works with shady DOM polyfills. An <input> in the proper shadow DOM can't reference any <datalist> that's in the light DOM, and so fails.

In order to work the <datalist> needs to be in the same shadow root as the <input>

@KeithHenry
Copy link

I've raised that as #595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants