Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old *cachedPairBlockHeightTokenPrice data from redis #28

Open
xadahiya opened this issue Dec 19, 2024 · 3 comments
Open

Cleanup old *cachedPairBlockHeightTokenPrice data from redis #28

xadahiya opened this issue Dec 19, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@xadahiya
Copy link
Member

Applies to Uniswap Use cases

When computed, token prices are continuously added to the uniswap_pair_cached_block_height_token_price zset. We must clean old keys to avoid infinite zset size growth in Redis.

Screenshot 2024-12-19 at 3 46 04 PM

@xadahiya xadahiya added the bug Something isn't working label Dec 19, 2024
@Seth-Schmidt
Copy link
Collaborator

Seth-Schmidt commented Dec 23, 2024

This change has been applied to all use cases:

aave - PowerLoom/snapshotter-computes@388c549

uniswapv2 - PowerLoom/snapshotter-computes@42c354b

uniswapv3 - PowerLoom/snapshotter-computes@2c9dea7

I also did a check on all other redis keys, and the data pruning is present for all unbound sets.

@anomit anomit self-assigned this Jan 16, 2025
@anomit
Copy link
Member

anomit commented Jan 20, 2025

Lets create PRs for merge into specific use case branches.

@Seth-Schmidt
Copy link
Collaborator

Have created PRs for UniswapV2:

Uniswap: PowerLoom/snapshotter-computes#14

And the Aave update was included as a part of the 3.3 update:

Aave: PowerLoom/snapshotter-computes#11

UniswapV3 was included in eth_uniswapv3_core, so it does not have a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants